Adapt NanoporeParser to allow second basecalling folder #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wow-such-code
approved these changes
Dec 12, 2022
Member
wow-such-code
left a comment
wow-such-code
left a comment
There was a problem hiding this comment.
lgtm, nice change with the failearly validation
Steffengreiner
deleted the
feature/dm-555-nanopore-with-second-basecalling-folder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Adjusts the nanopore parser to be able to parse an alternate nanopore output structure containing a folder generated due to the performance of a second basecalling