Adapt parsing of execution report to new regex #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven1103
reviewed
Aug 29, 2022
| if(filename.equals("software_versions.yml")){ | ||
| insertAsProperty(pipelineInformation, child, RequiredPipelineFileKeys.SOFTWARE_VERSIONS.getKeyName()) | ||
| } | ||
| else if(filename.matches("^execution_report.*")) { |
Contributor
There was a problem hiding this comment.
you can continue using switch and regex in Groovy:
Contributor
Author
There was a problem hiding this comment.
Interesting i didn't know groovy could do that since java does not have the same functionality 😓
sven1103
approved these changes
Aug 29, 2022
Contributor
sven1103
left a comment
sven1103
left a comment
There was a problem hiding this comment.
NIT: if you want to remain with the switch case, you can do so in Groovy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Fix parsing of execution_report.html parsing to allow for timestamps in the filename