Feature/dm 343 new maxquant model #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenniferboedker
suggested changes
May 17, 2022
Contributor
jenniferboedker
left a comment
jenniferboedker
left a comment
There was a problem hiding this comment.
Hi, thanks for your work!
I found that within the code the summary folder (see my comment) is contained and also the combined folder could in theory be parsed. Why did you keep them? I think we would need to remove them and make a major release afterwards. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the parser for MaxQuant data to handle the new model: experimentalDesignTemplate, summary and an unnecessary folder are removed. The sample ids file now needs a valid QBiC project code.