Invalidate cache when performing additional post operations#949
Merged
svivian merged 1 commit intoq2a:bugfixfrom Jul 12, 2023
Merged
Invalidate cache when performing additional post operations#949svivian merged 1 commit intoq2a:bugfixfrom
svivian merged 1 commit intoq2a:bugfixfrom
Conversation
Collaborator
|
Thanks for this. My original thought was to balance cache hits with too many cache invalidations, but I think you're right this allows longer cache periods (and therefore more time saved overall). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a few situations that were being missed when invalidating question caches:
Having these cache invalidations set would allow users to configure longer cache periods.