Skip to content

Fix negative upvoteCount wrongly displayed#738

Merged
svivian merged 1 commit intoq2a:bugfixfrom
pupi1985:patch-129
Feb 1, 2019
Merged

Fix negative upvoteCount wrongly displayed#738
svivian merged 1 commit intoq2a:bugfixfrom
pupi1985:patch-129

Conversation

@pupi1985
Copy link
Contributor

Fixes #733

@svivian svivian merged commit 27499f9 into q2a:bugfix Feb 1, 2019
@svivian
Copy link
Collaborator

svivian commented Feb 1, 2019

Bit of a strange one... I'm not sure exactly why we use – instead of a regular minus sign, if I'm not mistaken that's the wrong character anyway (should be used for ranges, not negativity). I don't see a need to overwrite $netvotes with its absolute value (we could use a separate variable for those == 1 checks).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants