Move bilinear import to avoid unnecessary warning#400
Merged
djhoese merged 1 commit intopytroll:mainfrom Dec 8, 2021
Merged
Conversation
to avoid the potential warning msg while import the top level pyresample module. This is because pyresample/__init__.py calls image.py, which import bilinear.py currently. And the later requires xarray/zarr, otherwise print out warning msg.
Codecov Report
@@ Coverage Diff @@
## main #400 +/- ##
=======================================
Coverage 93.81% 93.81%
=======================================
Files 65 65
Lines 11076 11077 +1
=======================================
+ Hits 10391 10392 +1
Misses 685 685
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
djhoese
changed the title
Member
|
Looks good. Thank you very much for clearing this up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the
bilinearmodule import from the top ofimage.pyto the function body ofImageContainerBilinear.resample().conda install -c conda-forge pyresampledoes not installxarrayandzarr. Thus, if one did not installxarrayandzarrmanually, runningimport pyresamplewill print out the following warning message:With this change, the top-level
import pyresample, which callsfrom pyresample import image, won't call thebilinearmodule, thus, avoid the warning msg.git diff origin/main **/*py | flake8 --diff