Repository navigation
refactor(config): simplify model and dataset target types to str - #173
Merged
aaishwarymishra merged 2 commits intoSep 7, 2026
Merged
Conversation
aaishwarymishra
self-requested a review
September 7, 2026 11:35
Member
There was a problem hiding this comment.
I dont think we need test for this
webdevsamran
force-pushed
the
refactor/config-str-types
branch
from
September 7, 2026 14:54
c85f9a1 to
a560862
Compare
Contributor
Author
|
Thanks for the feedback @aaishwarymishra! Removed the test additions as requested - the PR now only touches |
Member
|
Thanks :) |
omarfathy7
pushed a commit
to omarfathy7/trainite
that referenced
this pull request
Sep 7, 2026
…orch-ignite#173) Co-authored-by: Aaishwarya Mishra <[email protected]>
TahaZahid05
added a commit
that referenced
this pull request
Sep 9, 2026
* docs: add configuration and training guide (#156) * test: validate component registry (#157) * test: validate component registry * test: validate component registry --------- Co-authored-by: Aaishwarya Mishra <[email protected]> * refactor(config): simplify model and dataset target types to str (#173) Co-authored-by: Aaishwarya Mishra <[email protected]> * docs: fix component targets and config examples in training guide * docs: trim _target_ section in training guide * docs: restore dataset block in config example * docs: simplify counting example description --------- Co-authored-by: Taha Zahid <[email protected]> Co-authored-by: Mohammed Adel <[email protected]> Co-authored-by: Aaishwarya Mishra <[email protected]> Co-authored-by: Samran Asif <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on discussion in #31.
Description
Currently, several Pydantic configuration classes in
trainite/config/models.pyandtrainite/config/datasets.pytype theirtarget(_target_) fields as multi-lineLiteral[...]unions duplicating full import paths ("trainite.models..."vs"models..."). This makes the config definitions unnecessarily verbose and rejects custom user-provided implementations with strict validation errors.Following maintainer guidance (@aaishwarymishra in #31), this PR:
Literal[...]ontargetfields acrosstrainite/config/models.pyandtrainite/config/datasets.pywithstr.tests/config/base_test.pyensuring all model and dataset configs instantiate cleanly with string targets.