relax split requirement for prototype datasets#5186
Merged
pmeier merged 7 commits intopytorch:mainfrom Jan 17, 2022
Merged
Conversation
Contributor
💊 CI failures summary and remediationsAs of commit 1ba9c80 (more details on the Dr. CI page):
1 failure not recognized by patterns:
1 job timed out:
🚧 1 ongoing upstream failure:These were probably caused by upstream breakages that are not fixed yet.
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
NicolasHug
approved these changes
Jan 14, 2022
Member
NicolasHug
left a comment
NicolasHug
left a comment
There was a problem hiding this comment.
Thanks @pmeier , LGTM.
I just have minor questions. It makes sense to me not to make split a mandatory parameter, and to enforce our convention through consistent reviews in this case
NicolasHug
reviewed
Jan 14, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 17, 2022
Summary: * relax split requirement for prototype datasets * remove obsolete tests * appease mypy * fix failing test * fix load config test with default config Reviewed By: NicolasHug Differential Revision: D33618164 fbshipit-source-id: fea1fd6b4e40847beb5a8669331a00194236f574
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5185.
cc @pmeier @bjuncek