NOMRG Comments on prototype weights and model builders#4937
NOMRG Comments on prototype weights and model builders#4937NicolasHug wants to merge 3 commits intopytorch:mainfrom
Conversation
💊 CI failures summary and remediationsAs of commit 500f826 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
datumbox
left a comment
There was a problem hiding this comment.
Thanks for the comments @NicolasHug.
I'm going to go ahead and implement many of the proposals and send a PR (I'll add you as reviewer).
I also added more comments/context to those that I require more clarifications. Let me know your thoughts.
|
@NicolasHug I believe we addressed all the comments on this PR and we can close it. If there are more, happy to make the needed changes. Let me know |
|
Thanks for all the discussions @datumbox @fmassa , we can safely close this one now. Latest discussions were tracked in #4652 (comment) |
Here are a bunch of comments on the new weights prototype. I'm opening this as a PR (not to be merged) instead of an issue as I think it will better help localize each discussion.
Overall I don't have any major comment or concern, except maybe for the somewhat BC breaking changes of some model building functions. I think we can work around BC for some of them, but not all.