Use is_floating_point() to check for float image#3239
Merged
fmassa merged 4 commits intopytorch:masterfrom Jan 20, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3239 +/- ##
=======================================
Coverage 73.45% 73.45%
=======================================
Files 102 102
Lines 9329 9329
Branches 1494 1494
=======================================
Hits 6853 6853
Misses 2012 2012
Partials 464 464
Continue to review full report at Codecov.
|
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 1, 2021
Summary: Co-authored-by: Francisco Massa <[email protected]> Reviewed By: datumbox Differential Revision: D26156388 fbshipit-source-id: aa09fdf088ab2271da5ae25d764262d6246e4599
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiny refactoring to use directly
is_floating_point()to check if the tensor is of floating type. Unclear whether there was a specific reason why we did the check this way and what is the preferred idiom.This came up on another PR #3238, so it's worth clarifying.