Clean up and Document io.image enhancements (#3034)#3193
Clean up and Document io.image enhancements (#3034)#3193datumbox merged 3 commits intopytorch:masterfrom
Conversation
…read_mode.h, replace define with const in image_read_mode.h, add documentation to ImageReadMode enum
|
Hi @Sid2697! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but we do not have a signature on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Sid2697
changed the title
datumbox
left a comment
datumbox
left a comment
There was a problem hiding this comment.
Thanks for the PR! I left a few comments, let me know what you think.
Summary: * Update ImageReadMode error messages, add newline at the end of image_read_mode.h, replace define with const in image_read_mode.h, add documentation to ImageReadMode enum * Update readpng_cpu and readjpeg_cpu error messages * Update image.py documentation Reviewed By: fmassa Differential Revision: D25679209 fbshipit-source-id: 4376dbb0e005ae4a09b908daada8a5a5cfd9b2a8
3 participants
Fixes #3034
decode_pnganddecode_jpgas docs indecode_imageandread_imagesuggest the user to checkdecode_jpegfor the documentation. However, I have added the documentation to the enum.const.I hope this PR solves all the aforementioned issues. Do let me know if there are any concerns.