Merged
Conversation
datumbox
force-pushed
the
refactoring/cpp_project_structure
branch
8 times, most recently
from
47c8bc9 to
ac94f03
Compare
Codecov Report
@@ Coverage Diff @@
## master #3146 +/- ##
=======================================
Coverage 72.75% 72.75%
=======================================
Files 99 99
Lines 8979 8979
Branches 1431 1431
=======================================
Hits 6533 6533
Misses 1999 1999
Partials 447 447 Continue to review full report at Codecov.
|
datumbox
force-pushed
the
refactoring/cpp_project_structure
branch
3 times, most recently
from
6ee60e2 to
df7f550
Compare
fmassa
approved these changes
Dec 10, 2020
Member
fmassa
left a comment
fmassa
left a comment
There was a problem hiding this comment.
PR looks great, thanks a lot!
A few high level things we could do in a follow-up:
- split (if possible) the autograd bits into its own folder, as it's a backend as the others
- re-structure the video parts, as now they are scattered over 3 different folders (but needs some planning before doing it)
Summary: * Reduce unnecessary header inclusions in models and io. * Move autocast to separate folder and hide autograd implementation in an anonymous namespace. * Moving files in subfolders. Reviewed By: fmassa Differential Revision: D25461523 fbshipit-source-id: 756eeb6848aacaa474de4825ed4c1045d17e2cea
datumbox
force-pushed
the
refactoring/cpp_project_structure
branch
from
df7f550 to
3420106
Compare
Contributor
Author
13 tasks
This was referenced Jul 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POC for restructuring the C++ project based on discussions with @fmassa
ops.io.autocastin a separate folder inops.autogradforward/backward methods in an anonymous namespace.modelsandio.