Replace the Palette test file with a true RGB + Alpha png#2985
Merged
datumbox merged 3 commits intopytorch:masterfrom Nov 12, 2020
Merged
Replace the Palette test file with a true RGB + Alpha png#2985datumbox merged 3 commits intopytorch:masterfrom
datumbox merged 3 commits intopytorch:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2985 +/- ##
=======================================
Coverage 73.39% 73.39%
=======================================
Files 99 99
Lines 8825 8825
Branches 1391 1391
=======================================
Hits 6477 6477
Misses 1929 1929
Partials 419 419 Continue to review full report at Codecov.
|
bryant1410
pushed a commit
to bryant1410/vision-1
that referenced
this pull request
Nov 22, 2020
* Replace the Pallete with an RGB + Alpha file. * Correct typo on name.
vfdev-5
pushed a commit
to Quansight/vision
that referenced
this pull request
Dec 4, 2020
* Replace the Pallete with an RGB + Alpha file. * Correct typo on name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
rgbalpha_pytorch.pngfile added in PR #2984 was not an actual RGB + Alpha Transparency PNG but a Palette file.Here I replace it with an actual RGB+Alpha png, so that the unit-tests cover the 4 channel case. No changes required in the code. I also correct a typo on the name of the file.