Simplify the assertExpected method#2965
Merged
fmassa merged 2 commits intopytorch:masterfrom Nov 5, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2965 +/- ##
=======================================
Coverage 73.43% 73.43%
=======================================
Files 99 99
Lines 8813 8813
Branches 1391 1391
=======================================
Hits 6472 6472
Misses 1916 1916
Partials 425 425 Continue to review full report at Codecov.
|
fmassa
approved these changes
Nov 5, 2020
Member
fmassa
left a comment
fmassa
left a comment
There was a problem hiding this comment.
Thanks a lot for the cleanup!
I don't think we need this anymore, just putting some references there for some history.
bryant1410
pushed a commit
to bryant1410/vision-1
that referenced
this pull request
Nov 22, 2020
* Simplify the ACCEPT=True logic in assertExpected(). * Separate the expected filename estimation from assertExpected
vfdev-5
pushed a commit
to Quansight/vision
that referenced
this pull request
Dec 4, 2020
* Simplify the ACCEPT=True logic in assertExpected(). * Separate the expected filename estimation from assertExpected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The assertExpected method is unnecessarily complicated. In this PR I separate the estimation of the expected filename from the main assertion and simplify the logic of accepting a new expected value.