Skip to content

Static Analysis corrections on DeformConv#2885

Merged
fmassa merged 2 commits intopytorch:masterfrom
datumbox:refactor/deformconv_staticanalysis
Oct 26, 2020
Merged

Static Analysis corrections on DeformConv#2885
fmassa merged 2 commits intopytorch:masterfrom
datumbox:refactor/deformconv_staticanalysis

Conversation

@datumbox
Copy link
Copy Markdown
Contributor

@datumbox datumbox commented Oct 24, 2020

Minor refactoring based on static analysis and manual review of the code of DeformConv:

  • Convert unnecessary value parameter to constant reference.
  • Eliminate unnecessary casting.
  • Remove unnecessary namespace use.

Copy link
Copy Markdown
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmassa fmassa merged commit 5cb77a2 into pytorch:master Oct 26, 2020
@datumbox datumbox deleted the refactor/deformconv_staticanalysis branch October 26, 2020 12:15
bryant1410 pushed a commit to bryant1410/vision-1 that referenced this pull request Nov 22, 2020
* Convert to const reference and eliminate unnecessary bool casting.

* Removing unnecessary namespace use.
vfdev-5 pushed a commit to Quansight/vision that referenced this pull request Dec 4, 2020
* Convert to const reference and eliminate unnecessary bool casting.

* Removing unnecessary namespace use.
@datumbox datumbox mentioned this pull request Jan 5, 2021
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants