Separate random generation from transforms#115
Closed
fmassa wants to merge 1 commit intopytorch:masterfrom
Closed
Conversation
Contributor
|
👍 I believe this will not work with |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR factors out the random number generation from the transforms. This way, the same random transform can be applied to different inputs (from eventually different domains).
In the dataset, if the user wants to support the same random transforms applied to different input, a set of generators should be passed in the constructor of the dataset.
An example of how it should be used is presented as follows:
A few points worth noting:
RandomSizedCrop, the size of the image is required for the generator. We can add an extra*args, **kwargsin the call to eachgeneratemethod. I'll add that if you agree with that.generatorsto the constructor of the dataset, and callgenerateat each__getitem__, which might not be ideal.cc @bodokaiser @ellisbrown @desimone @felixgwu