-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Clean up and Document the io.image enhancements #3034
Copy link
Copy link
Closed
Description
PR #3024 introduced a few enhancements on the io.image methods used for reading JPEG and PNG images. The code changes were merged but there are a few nice-to-have improvements missing.
More specifically:
- Provide better error messages for JPEG and PNG when a specific
ImageReadModevalue is not supported. - Ensure that
image_read_mode.hhas a new line at the end of the file. - Replace the old
#definewith the newerconstexprexpression atimage_read_mode.h. - Move the documentation of
ImageReadModevalues from the methods to the enum.
Note: constexpr might cause problems on Windows. If that's the case, try using const instead.
Reactions are currently unavailable