Repository navigation
Mount repo to /repo instead of /work if the repo name is set - #4465
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
facebook-github-bot
added
the
CLA Signed
huydhn
marked this pull request as ready for review
August 9, 2023 23:16
malfet
approved these changes
Aug 9, 2023
facebook-github-bot
pushed a commit
to pytorch/executorch
that referenced
this pull request
Aug 16, 2023
Summary: This adds a build and test workflow using CMake on Linux. Here are some of my findings: * The build only works if `executorch` is checked out into a directory called `executorch`. Otherwise, including `<executorch/...>` would fail (pytorch/test-infra#4465) * Linking with GNU ld fails with the following error `/usr/bin/ld: -f may not be used without -shared`, which I'm not sure what it means atm, so I switch to LLD by adding `add_link_options("-fuse-ld=lld")` for clang * I still couldn't make this work on Mac yet because `libprogram_schema.a` is empty and Mac `ar` refuses to link the library. So that's an issue for another day. ``` /Library/Developer/CommandLineTools/usr/bin/ar qc libprogram_schema.a ar: no archive members specified ``` Pull Request resolved: #52 Reviewed By: dbort Differential Revision: D48216923 Pulled By: huydhn fbshipit-source-id: 0ba751e3e849ec6779b19338253dd73b7ef0f3c8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to address the build failure https://github.com/pytorch/executorch/actions/runs/5814461344/job/15764455362?pr=52 where the cmake build expects the repo name in the include path, not
/work