Repository navigation
[BE] Add shareable calculate-docker-image GHA - #4397
Merged
Merged
Conversation
|
@huydhn is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
huydhn
marked this pull request as ready for review
July 18, 2023 02:26
Contributor
Author
|
These testing PRs show how this action is used across PyTorch and Executorch, both in |
huydhn
changed the title
This was referenced Jul 18, 2023
atalman
approved these changes
Jul 18, 2023
malfet
approved these changes
Jul 18, 2023
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Jul 19, 2023
Switch from PyTorch `calculate-docker-image` GHA to its shareable version on test-infra pytorch/test-infra#4397. I will clean up PyTorch `calculate-docker-image` GHA in a separate PR after landing this one. Pull Request resolved: #105372 Approved by: https://github.com/malfet
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Jul 24, 2023
As this has been replaced by the more generic calculate-docker-image on test-infra pytorch/test-infra#4397 in: * pytorch/test-infra#4399 * and #105372 Pull Request resolved: #105752 Approved by: https://github.com/Skylion007
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors the logic in PyTorch https://github.com/pytorch/pytorch/blob/main/.github/actions/calculate-docker-image/action.yml to a shareable GHA. Notably, the changes include:
.ci/docker, with abuild.shscript entry. The usage isbuild.sh "${IMAGE_NAME}" -t "${DOCKER_IMAGE}"as how it's used in PyTorch atmalways-rebuildandpush(set to true to push the image to ECR)One hidden caveat is that
calculate-docker-imagerequires a full checkout to work as it tries to figure out the Docker tag of the base commit. This means thatfetch-depth: 0is needed to use this action.This action can then be used in the upcoming CI change on Executorch where the repo could build and use its own Docker image(s).
Testing