Enable ruff in lintrunner by justinchuby · Pull Request #99785 · pytorch/pytorch

justinchuby · 2023-04-22T02:32:52Z

Stack from ghstack (oldest at bottom):

-> Enable ruff in lintrunner #99785

This change

Implements the ruff linter in pytorch lintrunner. It is adapted from https://github.com/justinchuby/lintrunner-adapters/blob/main/lintrunner_adapters/adapters/ruff_linter.py. It does both linting and fixing. 🔧
Migrated all flake8 configs to the ruff config and enabled it for the repo. ✅
ruff lints the whole repo in under 2s 🤯

Fixes #94737 Replaces #99280

@huydhn @Skylion007

`🤖 Generated by Copilot at 6b982dd`

Summary

🧹🛠️🎨

Add [tool.ruff] section to pyproject.toml to configure ruff code formatter and linter. This change aims to improve code quality and consistency with a single tool.

ruff cleans the code
like a spring breeze in the fields
pyproject.toml

Walkthrough

Configure ruff code formatter and linter for the whole project (link)

This change implements the ruff linter in pytorch lintrunner. It is adapted from https://github.com/justinchuby/lintrunner-adapters/blob/main/lintrunner_adapters/adapters/ruff_linter.py. It does both linting and fixing. This change also migrated all flake8 configs to the ruff config. We plan to enable ruff in `torch.onnx`. Fixes #94737 [ghstack-poisoned]

pytorch-bot · 2023-04-22T02:32:55Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/99785

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 14dd3db:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This change implements the ruff linter in pytorch lintrunner. It is adapted from https://github.com/justinchuby/lintrunner-adapters/blob/main/lintrunner_adapters/adapters/ruff_linter.py. It does both linting and fixing. This change also migrated all flake8 configs to the ruff config. We plan to enable ruff in `torch.onnx`. Fixes #94737 huydhn Skylion007 [ghstack-poisoned]

### This change - Implements the ruff linter in pytorch lintrunner. It is adapted from https://github.com/justinchuby/lintrunner-adapters/blob/main/lintrunner_adapters/adapters/ruff_linter.py. It does **both linting and fixing**. 🔧 - Migrated all flake8 configs to the ruff config and enabled it for the repo. ✅ - **`ruff` lints the whole repo in under 2s** 🤯 Fixes #94737 Replaces #99280 huydhn Skylion007  ### <samp>🤖 Generated by Copilot at 6b982dd</samp> ### Summary 🧹🛠️🎨  Add `[tool.ruff]` section to `pyproject.toml` to configure `ruff` code formatter and linter. This change aims to improve code quality and consistency with a single tool. > _`ruff` cleans the code_ > _like a spring breeze in the fields_ > _`pyproject.toml`_ ### Walkthrough * Configure `ruff` code formatter and linter for the whole project ([link](https://github.com/pytorch/pytorch/pull/99785/files?diff=unified&w=0#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711R22-R79)) [ghstack-poisoned]

This change implements the ruff linter in pytorch lintrunner. It is adapted from https://github.com/justinchuby/lintrunner-adapters/blob/main/lintrunner_adapters/adapters/ruff_linter.py. It does both linting and fixing. This change also migrated all flake8 configs to the ruff config. We plan to enable ruff in `torch.onnx`. Fixes #94737 ghstack-source-id: ffc738e Pull Request resolved: #99785

malfet · 2023-04-22T04:33:39Z

tools/linter/adapters/ruff_linter.py

@@ -0,0 +1,462 @@
+"""Adapter for https://github.com/charliermarsh/ruff."""
+
+from __future__ import annotations


Is this really needed?

Suggested change

from __future__ import annotations

This is needed for python 3.8 compatibility for the annotations eg list[…]

Skylion007 · 2023-04-22T15:00:46Z

tools/linter/adapters/ruff_linter.py

+            try:
+                for lint_message in future.result():
+                    lint_message.display()
+            except Exception:


Bare exception catching as bad and will even catch syntax errors. (it's defiitely a flake8-bugprone rule I want to enable eventually.

I think we want to catch any and all exceptions here so that they are reported to lintrunner. I will add a comment

Added a comment

pyproject.toml

### This change - Implements the ruff linter in pytorch lintrunner. It is adapted from https://github.com/justinchuby/lintrunner-adapters/blob/main/lintrunner_adapters/adapters/ruff_linter.py. It does **both linting and fixing**. 🔧 - Migrated all flake8 configs to the ruff config and enabled it for the repo. ✅ - **`ruff` lints the whole repo in under 2s** 🤯 Fixes #94737 Replaces #99280 huydhn Skylion007  ### <samp>🤖 Generated by Copilot at 6b982dd</samp> ### Summary 🧹🛠️🎨  Add `[tool.ruff]` section to `pyproject.toml` to configure `ruff` code formatter and linter. This change aims to improve code quality and consistency with a single tool. > _`ruff` cleans the code_ > _like a spring breeze in the fields_ > _`pyproject.toml`_ ### Walkthrough * Configure `ruff` code formatter and linter for the whole project ([link](https://github.com/pytorch/pytorch/pull/99785/files?diff=unified&w=0#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711R22-R79)) [ghstack-poisoned]

This change implements the ruff linter in pytorch lintrunner. It is adapted from https://github.com/justinchuby/lintrunner-adapters/blob/main/lintrunner_adapters/adapters/ruff_linter.py. It does both linting and fixing. This change also migrated all flake8 configs to the ruff config. We plan to enable ruff in `torch.onnx`. Fixes #94737 ghstack-source-id: 6186768 Pull Request resolved: #99785 Signed-off-by: Justin Chu <[email protected]>

Skylion007 · 2023-04-23T15:18:30Z

.lintrunner.toml

 ]
+
+[[linter]]
+code = 'RUFF'


One nit is that there should be two comments reminding future contributors to try keep the flake8 config and ruff config in sync. Otherwise, the rule will only be enabled / disabled in one which will cause issues.

### This change - Implements the ruff linter in pytorch lintrunner. It is adapted from https://github.com/justinchuby/lintrunner-adapters/blob/main/lintrunner_adapters/adapters/ruff_linter.py. It does **both linting and fixing**. 🔧 - Migrated all flake8 configs to the ruff config and enabled it for the repo. ✅ - **`ruff` lints the whole repo in under 2s** 🤯 Fixes #94737 Replaces #99280 huydhn Skylion007  ### <samp>🤖 Generated by Copilot at 6b982dd</samp> ### Summary 🧹🛠️🎨  Add `[tool.ruff]` section to `pyproject.toml` to configure `ruff` code formatter and linter. This change aims to improve code quality and consistency with a single tool. > _`ruff` cleans the code_ > _like a spring breeze in the fields_ > _`pyproject.toml`_ ### Walkthrough * Configure `ruff` code formatter and linter for the whole project ([link](https://github.com/pytorch/pytorch/pull/99785/files?diff=unified&w=0#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711R22-R79)) [ghstack-poisoned]

This change implements the ruff linter in pytorch lintrunner. It is adapted from https://github.com/justinchuby/lintrunner-adapters/blob/main/lintrunner_adapters/adapters/ruff_linter.py. It does both linting and fixing. This change also migrated all flake8 configs to the ruff config. We plan to enable ruff in `torch.onnx`. Fixes #94737 ghstack-source-id: f017aad Pull Request resolved: #99785 Signed-off-by: Justin Chu <[email protected]>

justinchuby · 2023-04-24T16:12:34Z

@pytorchbot merge

pytorchmergebot · 2023-04-24T16:14:33Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Skylion007 · 2023-04-24T16:16:10Z

torch/distributed/pipeline/sync/microbatch.py


    def _setitem_by_slice(self, index: slice, value) -> None:
-        if not (index.start is index.stop is index.step is None):
+        if not (index.start is index.stop is index.step is None):  # noqa: E714


May want to file this issue with ruff ;)

astral-sh/ruff#4082

justinchuby · 2023-04-24T16:16:30Z

@pytorchbot merge -f "lintrunner only change"

pytorchmergebot · 2023-04-24T16:18:36Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

charliermarsh · 2023-04-25T00:01:09Z

.flake8

+# NOTE: **Mirror any changes** to this file the [tool.ruff] config in pyproject.toml
+# before we can fully move to use ruff
 enable-extensions = G
 select = B,C,E,F,G,P,SIM1,T4,W,B9


Sorry for the drive-by comment, but if there's anything missing in Ruff that you'd like to see implemented, feel free to bug me

justinchuby mentioned this pull request Apr 22, 2023

Fix flake8 lint errors reported by ruff #99784

Closed

pytorch-bot bot added the topic: not user facing topic category label Apr 22, 2023

justinchuby mentioned this pull request Apr 22, 2023

Enable ruff in lintrunner #99280

Closed

justinchuby requested review from Skylion007 and huydhn April 22, 2023 02:34

justinchuby added the module: lint Issues related to our Python/C++ lint rules (run by Travis) label Apr 22, 2023

pytorchbot added the open source label Apr 22, 2023

malfet approved these changes Apr 22, 2023

View reviewed changes

Skylion007 reviewed Apr 22, 2023

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

justinchuby mentioned this pull request Apr 22, 2023

Fix flake8 lint errors reported by ruff - take 2 #99798

Closed

justinchuby mentioned this pull request Apr 22, 2023

Fix flake8 lint errors - part 2 - manual fixes #99799

Closed

Skylion007 approved these changes Apr 23, 2023

View reviewed changes

Skylion007 reviewed Apr 23, 2023

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 24, 2023

pytorchmergebot added the merging label Apr 24, 2023

Skylion007 reviewed Apr 24, 2023

View reviewed changes

pytorchmergebot added Merged and removed merging labels Apr 24, 2023

pytorchmergebot closed this in 7d2a18d Apr 24, 2023

charliermarsh reviewed Apr 25, 2023

View reviewed changes

facebook-github-bot deleted the gh/justinchuby/34/head branch June 8, 2023 17:43

adamjstewart mentioned this pull request Apr 7, 2024

Use ruff torchgeo/torchgeo#1986

Closed

		@@ -0,0 +1,462 @@
		"""Adapter for https://github.com/charliermarsh/ruff."""

		from __future__ import annotations

Conversation

justinchuby commented Apr 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

This change

🤖 Generated by Copilot at 6b982dd

Summary

Walkthrough

Uh oh!

pytorch-bot bot commented Apr 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/99785

✅ No Failures

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

justinchuby Apr 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

justinchuby commented Apr 24, 2023

Uh oh!

pytorchmergebot commented Apr 24, 2023

Merge started

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

justinchuby commented Apr 24, 2023

Uh oh!

pytorchmergebot commented Apr 24, 2023

Merge started

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

justinchuby commented Apr 22, 2023 •

edited

Loading

`🤖 Generated by Copilot at 6b982dd`

pytorch-bot bot commented Apr 22, 2023 •

edited

Loading

justinchuby Apr 22, 2023 •

edited

Loading