Remove the generation of storage files #9954
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuhrsch
requested review from
apaszke,
colesbury,
ebetica,
ezyang,
gchanan,
goldsborough,
pietern,
soumith,
teng-li and
zdevito
as code owners
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
cpuhrsch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
gchanan
approved these changes
Jul 27, 2018
Contributor
gchanan
left a comment
gchanan
left a comment
There was a problem hiding this comment.
looks fine; I don't know what the final model is supposed to be (i.e. if Storage is even something users would interact with). If not, it might be cleaner just to create a StorageImpl at all the call sites instead of adding constructors to Storage.
Contributor
Author
|
@gchanan - Good point! I'll add this to the list. |
ezyang
approved these changes
Jul 29, 2018
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 30, 2018
Summary: Pull Request resolved: pytorch/pytorch#9954 Reviewed By: gchanan Differential Revision: D9035947 Pulled By: cpuhrsch fbshipit-source-id: 9b56c7a68e3f562ea11b9265a5fa234838f2b4e0
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
Summary: Pull Request resolved: pytorch#9954 Reviewed By: gchanan Differential Revision: D9035947 Pulled By: cpuhrsch fbshipit-source-id: 9b56c7a68e3f562ea11b9265a5fa234838f2b4e0
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
Summary: Pull Request resolved: pytorch#9954 Reviewed By: gchanan Differential Revision: D9035947 Pulled By: cpuhrsch fbshipit-source-id: 9b56c7a68e3f562ea11b9265a5fa234838f2b4e0 Don't use the XML reporter for Catch2. (pytorch#10012) Summary: Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: pytorch#10012 Differential Revision: D9057766 Pulled By: ezyang fbshipit-source-id: 12148a8cf3061423c61b3e7b36864dfcdb1138a1 Fix Caffe2CTScan error (pytorch#9962) Summary: Pull Request resolved: pytorch#9962 att Reviewed By: hlu1 Differential Revision: D9036869 fbshipit-source-id: 3155af00c62d489f998cbfba07121c4fd20e1c6f Enable n-dimensional empty tensors. (pytorch#9947) Summary: These could use some autograd tests, which are coming in a later PR, but using them in autograd is probably pretty rare. Pull Request resolved: pytorch#9947 Reviewed By: ezyang Differential Revision: D9032778 Pulled By: gchanan fbshipit-source-id: fa5a6509d3bac31ea4fae25143e82de62daabfbd
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Pull Request resolved: pytorch#9954 Reviewed By: gchanan Differential Revision: D9035947 Pulled By: cpuhrsch fbshipit-source-id: 9b56c7a68e3f562ea11b9265a5fa234838f2b4e0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.