Add (constant size) TensorLists to JIT, use them in cat and stack nodes #9948
Conversation
apaszke
requested review from
Yangqing,
anderspapitto,
bddppq,
colesbury,
dzhulgakov,
ezyang,
gchanan,
houseroad,
jamesr66a,
smessmer,
soumith and
zdevito
as code owners
apaszke
force-pushed
the
jit_list_flatten
branch
from
bed465e to
467d7d1
Compare
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
apaszke has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
apaszke
force-pushed
the
jit_list_flatten
branch
from
467d7d1 to
ed70fd8
Compare
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
apaszke has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@pytorchbot retest this please |
zdevito
left a comment
zdevito
left a comment
There was a problem hiding this comment.
This looks good! Cleans up a lot of stuff.
tools/jit/gen_jit_dispatch.py
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
tools/jit/gen_jit_dispatch.py
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
tools/jit/gen_jit_dispatch.py
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
torch/csrc/jit/ir.cpp
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
torch/csrc/jit/script/compiler.cpp
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
apaszke
force-pushed
the
jit_list_flatten
branch
from
c4b8a29 to
1b3503c
Compare
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
apaszke has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
…es (pytorch#9948) Summary: zdevito Pull Request resolved: pytorch#9948 Reviewed By: ezyang Differential Revision: D9033666 Pulled By: apaszke fbshipit-source-id: 02d75e391ed6dee62500842df50f0b6ee5e38846
… functions (#9969) Summary: This lays out initial support for taking and returning a richer set of types than only tensors. Floats and ints are already valid, lists are straightforward to add, tuples need some discussion. Based on top of #9948. Review only the last commit. zdevito Pull Request resolved: #9969 Reviewed By: zdevito Differential Revision: D9076973 Pulled By: apaszke fbshipit-source-id: 5a1fe912ea6b79ab2bfd0dcce265eb05855b5ff0
…es (pytorch#9948) Summary: zdevito Pull Request resolved: pytorch#9948 Reviewed By: ezyang Differential Revision: D9033666 Pulled By: apaszke fbshipit-source-id: 02d75e391ed6dee62500842df50f0b6ee5e38846
… functions (pytorch#9969) Summary: This lays out initial support for taking and returning a richer set of types than only tensors. Floats and ints are already valid, lists are straightforward to add, tuples need some discussion. Based on top of pytorch#9948. Review only the last commit. zdevito Pull Request resolved: pytorch#9969 Reviewed By: zdevito Differential Revision: D9076973 Pulled By: apaszke fbshipit-source-id: 5a1fe912ea6b79ab2bfd0dcce265eb05855b5ff0
6 participants
@zdevito