Add essential PATH for the Windows PyTorch loading process #9920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjc123
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
soumith
approved these changes
Jul 27, 2018
Collaborator
Author
Contributor
|
@peterjc123 that would be quite useful. |
Collaborator
Author
|
@soumith Maybe we should merge this first. I'll create the utility script in a separate PR. |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
) Summary: Fixes pytorch#9818. It seems original Python doesn't add `[PYTHONPATH]\Library\bin` into `PATH`. We try to add it before dll loading process. Pull Request resolved: pytorch#9920 Differential Revision: D9040825 Pulled By: soumith fbshipit-source-id: c07fff71b2aea254a396042ab677696f6829aac7
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
) Summary: Fixes pytorch#9818. It seems original Python doesn't add `[PYTHONPATH]\Library\bin` into `PATH`. We try to add it before dll loading process. Pull Request resolved: pytorch#9920 Differential Revision: D9040825 Pulled By: soumith fbshipit-source-id: c07fff71b2aea254a396042ab677696f6829aac7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9818.
It seems original Python doesn't add
[PYTHONPATH]\Library\binintoPATH. We try to add it before dll loading process.