Skip to content

Revert "[CUDA12] set_device change (#94864)"#99162

Closed
ngimel wants to merge 2 commits intomasterfrom
ngimel/set_device_revert
Closed

Revert "[CUDA12] set_device change (#94864)"#99162
ngimel wants to merge 2 commits intomasterfrom
ngimel/set_device_revert

Conversation

@ngimel
Copy link
Collaborator

@ngimel ngimel commented Apr 14, 2023

This reverts commit 69eef5a.

Due to flaky tests on fsdp #94864 (comment)

@ngimel ngimel requested review from albanD and soulitzer as code owners April 14, 2023 16:09
@pytorch-bot
Copy link

pytorch-bot bot commented Apr 14, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/99162

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 33c69df:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: sparse release notes category label Apr 14, 2023
@ngimel ngimel added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category and removed release notes: sparse release notes category labels Apr 14, 2023
@ngimel
Copy link
Collaborator Author

ngimel commented Apr 15, 2023

After investigation #99011 (comment) set_device PR is not to blame, closing.

@ngimel ngimel closed this Apr 15, 2023
@github-actions github-actions bot deleted the ngimel/set_device_revert branch October 14, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants