Skip to content

Conversation

@t-vi
Copy link
Collaborator

@t-vi t-vi commented Jul 26, 2018

I hope this helps me for the windows build failure in #9628 .

@ssnl
Copy link
Collaborator

ssnl commented Jul 27, 2018

@peterjc123 does this look reasonable?

Copy link
Collaborator

@peterjc123 peterjc123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

zdevito pushed a commit to zdevito/ATen that referenced this pull request Jul 27, 2018
Summary:
I hope this helps me for the windows build failure in #9628 .
Pull Request resolved: pytorch/pytorch#9904

Differential Revision: D9026715

Pulled By: soumith

fbshipit-source-id: bb97d41d060823f5a37bfc9a1659815b8b9f4eab
jramseyer pushed a commit to jramseyer/pytorch that referenced this pull request Jul 30, 2018
Summary:
I hope this helps me for the windows build failure in pytorch#9628 .
Pull Request resolved: pytorch#9904

Differential Revision: D9026715

Pulled By: soumith

fbshipit-source-id: bb97d41d060823f5a37bfc9a1659815b8b9f4eab
goodlux pushed a commit to goodlux/pytorch that referenced this pull request Aug 15, 2018
Summary:
I hope this helps me for the windows build failure in pytorch#9628 .
Pull Request resolved: pytorch#9904

Differential Revision: D9026715

Pulled By: soumith

fbshipit-source-id: bb97d41d060823f5a37bfc9a1659815b8b9f4eab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants