Skip to content

Pass shape infos to ONNX -> Caffe2 C++ conversion backend #9870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bddppq wants to merge 2 commits into from
Closed

Pass shape infos to ONNX -> Caffe2 C++ conversion backend #9870

bddppq wants to merge 2 commits into from

Conversation

@bddppq
Copy link
Contributor

@bddppq bddppq commented Jul 26, 2018 •
edited
Loading

And let Gemm conversion to inspect the input C to try converting to FC.

@bddppq bddppq requested review from houseroad and yinghai July 26, 2018 08:58
facebook-github-bot
facebook-github-bot reviewed Jul 26, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot reviewed Jul 26, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@bddppq
Copy link
Contributor Author

bddppq commented Jul 26, 2018

@colesbury

yinghai
yinghai approved these changes Jul 26, 2018
View reviewed changes
Copy link
Contributor

@yinghai yinghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. Some nits.

caffe2/onnx/backend.h Outdated

This comment was marked as off-topic.

Sign in to view

caffe2/onnx/backend.h Outdated

This comment was marked as off-topic.

Sign in to view

caffe2/python/pybind_state.cc Outdated

This comment was marked as off-topic.

Sign in to view

@bddppq bddppq force-pushed the shape-conversion branch from ebdde6e to 2f234e0 Compare July 26, 2018 17:11
facebook-github-bot
facebook-github-bot reviewed Jul 26, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@bddppq bddppq force-pushed the shape-conversion branch from 2f234e0 to aa78090 Compare July 26, 2018 17:22
facebook-github-bot
facebook-github-bot reviewed Jul 26, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

houseroad
houseroad approved these changes Jul 26, 2018
View reviewed changes
Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

caffe2/python/onnx/backend.py Outdated
value_infos = []
for name in node_def.input:
if pred_model is not None:
for vi in itertools.chain(pred_model.graph.input, pred_model.graph.output):

This comment was marked as off-topic.

Sign in to view

facebook-github-bot
facebook-github-bot reviewed Jul 26, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

jramseyer pushed a commit to jramseyer/pytorch that referenced this pull request Jul 30, 2018
@bddppq @jramseyer
Pass shape infos to ONNX -> Caffe2 C++ conversion backend (pytorch#9870)
6d88175 
Summary:
And let Gemm conversion to inspect the input `C` to try converting to FC.
Pull Request resolved: pytorch#9870

Reviewed By: houseroad

Differential Revision: D9013198

Pulled By: bddppq

fbshipit-source-id: b4c509cfccca238262e1c406b004e66cef256321
goodlux pushed a commit to goodlux/pytorch that referenced this pull request Aug 15, 2018
@bddppq
Pass shape infos to ONNX -> Caffe2 C++ conversion backend (pytorch#9870)
e7e7080 
Summary:
And let Gemm conversion to inspect the input `C` to try converting to FC.
Pull Request resolved: pytorch#9870

Reviewed By: houseroad

Differential Revision: D9013198

Pulled By: bddppq

fbshipit-source-id: b4c509cfccca238262e1c406b004e66cef256321
@ezyang ezyang added the merged label Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@houseroad houseroad houseroad approved these changes

+1 more reviewer

@yinghai yinghai yinghai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bddppq @yinghai @facebook-github-bot @houseroad @ezyang