Use qualified name at::Half in Dispatch.h #9848
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes AT_DISPATCH_ALL_TYPES_AND_HALF valid outside of the at namespace. See pytorch/extension-cpp#15
colesbury
requested review from
apaszke,
ezyang,
gchanan,
soumith and
zdevito
as code owners
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@colesbury has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
soumith
approved these changes
Jul 26, 2018
aten/src/ATen/Dispatch.h
Outdated
| switch (the_type.scalarType()) { \ | ||
| AT_PRIVATE_CASE_TYPE(at::ScalarType::Double, double, __VA_ARGS__) \ | ||
| AT_PRIVATE_CASE_TYPE(at::ScalarType::Float, float, __VA_ARGS__) \ | ||
| AT_PRIVATE_CASE_TYPE(at::ScalarType::Half, Half, __VA_ARGS__) \ |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@colesbury has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@colesbury is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 27, 2018
Summary: This makes AT_DISPATCH_ALL_TYPES_AND_HALF valid outside of the at namespace. See pytorch/extension-cpp#15 Pull Request resolved: pytorch/pytorch#9848 Differential Revision: D9006921 Pulled By: colesbury fbshipit-source-id: a6e4f097a9d6fb85c921e1c9b9ea25d0f2db06dc
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
Summary: This makes AT_DISPATCH_ALL_TYPES_AND_HALF valid outside of the at namespace. See pytorch/extension-cpp#15 Pull Request resolved: pytorch#9848 Differential Revision: D9006921 Pulled By: colesbury fbshipit-source-id: a6e4f097a9d6fb85c921e1c9b9ea25d0f2db06dc
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: This makes AT_DISPATCH_ALL_TYPES_AND_HALF valid outside of the at namespace. See pytorch/extension-cpp#15 Pull Request resolved: pytorch#9848 Differential Revision: D9006921 Pulled By: colesbury fbshipit-source-id: a6e4f097a9d6fb85c921e1c9b9ea25d0f2db06dc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes AT_DISPATCH_ALL_TYPES_AND_HALF valid outside of the at
namespace.
See pytorch/extension-cpp#15