Skip to content

Conversation

@ashishfarmer
Copy link

The PR contains:
Fixes for running MIOpen conv operator in a multi worker scenario, along with a performance fix
Fixing a typo in MIOpen pool op and adding some extra checks for MIOpen spatial BN op

@bddppq

@ashishfarmer ashishfarmer changed the title MIOpen fixes MIOpen fixes for Caffe2 Jul 25, 2018
@bddppq
Copy link
Contributor

bddppq commented Jul 25, 2018

@pytorchbot retest this please

@ezyang
Copy link
Contributor

ezyang commented Jul 25, 2018

@pytorchbot retest this please

1 similar comment
@bddppq
Copy link
Contributor

bddppq commented Jul 25, 2018

@pytorchbot retest this please

@bddppq bddppq closed this Jul 25, 2018
@bddppq bddppq reopened this Jul 25, 2018
@petrex
Copy link
Contributor

petrex commented Jul 26, 2018

@bddppq
is it ok we disable the test health check from hypothesis?

@bddppq
Copy link
Contributor

bddppq commented Jul 26, 2018

@petrex yes I would like to disable this filter too much health check globally but I don't know how to do it. Maybe just disable this offending one for now caffe2/python/operator_test/fc_operator_test.py::TestFcOperator::test_fc

@bddppq
Copy link
Contributor

bddppq commented Jul 26, 2018

#9865

@bddppq
Copy link
Contributor

bddppq commented Jul 26, 2018

@pytorchbot retest this please

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@bddppq bddppq self-requested a review July 26, 2018 09:02
Copy link
Contributor

@bddppq bddppq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

jramseyer pushed a commit to jramseyer/pytorch that referenced this pull request Jul 30, 2018
Summary:
The PR contains:
Fixes for running MIOpen conv operator in a multi worker scenario, along with a performance fix
Fixing a typo in MIOpen pool op and adding some extra checks for MIOpen spatial BN op

bddppq
Pull Request resolved: pytorch#9842

Differential Revision: D9012512

Pulled By: bddppq

fbshipit-source-id: 270e1323c20fbfbc4b725f9a4ff34cd073ddaaa8
goodlux pushed a commit to goodlux/pytorch that referenced this pull request Aug 15, 2018
Summary:
The PR contains:
Fixes for running MIOpen conv operator in a multi worker scenario, along with a performance fix
Fixing a typo in MIOpen pool op and adding some extra checks for MIOpen spatial BN op

bddppq
Pull Request resolved: pytorch#9842

Differential Revision: D9012512

Pulled By: bddppq

fbshipit-source-id: 270e1323c20fbfbc4b725f9a4ff34cd073ddaaa8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants