[EASY] Add AT_CHECK for null storage. #9823
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Z. Yang <[email protected]>
ezyang
requested review from
apaszke,
colesbury,
gchanan,
soumith and
zdevito
as code owners
cpuhrsch
reviewed
Jul 25, 2018
aten/src/TH/THTensor.hpp
Outdated
| // initialized; we never have tensors that don't have any storage. | ||
| // However, for Caffe2, this is not true, because they have permitted | ||
| // tensors to be allocated without specifying what scalar type | ||
| // they should be, only to be filled with GetMutableData is called |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Signed-off-by: Edward Z. Yang <[email protected]>
Contributor
Author
|
@pytorchbot retest this please |
gchanan
approved these changes
Jul 26, 2018
Contributor
gchanan
left a comment
gchanan
left a comment
There was a problem hiding this comment.
should we guard the setters as well?
Contributor
Author
|
Seems like a reasonable thing to do. |
Signed-off-by: Edward Z. Yang <[email protected]>
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@ezyang shipit shipit |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 31, 2018
Summary: Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: pytorch/pytorch#9823 Differential Revision: D9029433 Pulled By: ezyang fbshipit-source-id: 6101556305593c66f618b20d8c2a084ae2558ea8
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: pytorch#9823 Differential Revision: D9029433 Pulled By: ezyang fbshipit-source-id: 6101556305593c66f618b20d8c2a084ae2558ea8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Edward Z. Yang [email protected]