Skip to content

use libcusolver_lapack_static.a for CUDA>=12 #98072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ptrblck wants to merge 2 commits into from
Closed

use libcusolver_lapack_static.a for CUDA>=12 #98072

ptrblck wants to merge 2 commits into from

Conversation

@ptrblck
Copy link
Collaborator

@ptrblck ptrblck commented Mar 31, 2023

Needed for pytorch/builder#1374 to enable nightly CUDA12.1 builds.

From the cuSOLVER release notes (https://docs.nvidia.com/cuda/cusolver/index.html#link-third-party-lapack-library):

The liblapack_static.a library is deprecated and will be removed in the next major release. Use the libcusolver_lapack_static.a instead.

Note that "next major release" corresponds to CUDA 12, not 13.
The fix was verified locally on an H100 using pytorch/builder#1374 and pip wheels were properly built:

>>> torch.version.cuda
'12.1'
>>> torch.backends.cudnn.version()
8801
>>> conv =nn.Conv2d(3, 3, 3).cuda()
>>> x = torch.randn(1, 3, 224, 224).cuda()
>>> out = conv(x)
>>> out.sum()
tensor(5386.9219, device='cuda:0', grad_fn=<SumBackward0>)

CC @malfet @atalman @ngimel

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 31, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/98072

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 94551ac:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Mar 31, 2023
@ptrblck ptrblck mentioned this pull request Mar 31, 2023
Merged
@malfet
Copy link
Contributor

malfet commented Mar 31, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 31, 2023
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Mar 31, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@atalman atalman atalman approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ptrblck @malfet @pytorchmergebot @atalman @pytorchbot