Skip to content

Conversation

@virtan
Copy link
Contributor

@virtan virtan commented Jul 25, 2018

No description provided.

@Yangqing Yangqing requested a review from bddppq July 25, 2018 23:18
@Yangqing
Copy link
Contributor

Thanks! This looks pretty good, cc @bddppq for a double check :)

m.def("num_cuda_devices", &NumCudaDevices);
m.def("get_cuda_version", &CudaVersion);
m.def("get_cudnn_version", &cudnnCompiledVersion);
m.def("cudnn_convolution_fwd_algo_count", &CudnnConvolutionFwdAlgoCount);

This comment was marked as off-topic.

This comment was marked as off-topic.

engine=st.sampled_from(["", "EIGEN"]),
shared_buffer=st.booleans(),
use_bias=st.booleans(),
force_algo_fwd=_cudnn_convolution_algo_count("fwd"),

This comment was marked as off-topic.

This comment was marked as off-topic.

force_algo_dgrad=_cudnn_convolution_algo_count("dgrad"),
force_algo_wgrad=_cudnn_convolution_algo_count("wgrad"),
**hu.gcs)
def test_convolution_separate_stride_pad_layout(self, op_type,

This comment was marked as off-topic.

This comment was marked as off-topic.

self.assertDeviceChecks(dc, op, inputs, [0])
except RuntimeError as e:
es = str(e)
if es.find("status == CUDNN_STATUS_SUCCESS") < 0 \

This comment was marked as off-topic.

This comment was marked as off-topic.

except RuntimeError as e:
es = str(e)
if es.find("status == CUDNN_STATUS_SUCCESS") < 0 \
or es.find("CUDNN_STATUS_NOT_SUPPORTED") < 0:

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

@bddppq
Copy link
Contributor

bddppq commented Jul 26, 2018

@pytorchbot retest this please

@virtan
Copy link
Contributor Author

virtan commented Jul 26, 2018

I got into compilation issues, probably due to the merge with master. Re-merging again to confirm.

@virtan
Copy link
Contributor Author

virtan commented Jul 26, 2018

Looks good, should actually pass tests

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

virtan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

jramseyer pushed a commit to jramseyer/pytorch that referenced this pull request Jul 30, 2018
Summary: Pull Request resolved: pytorch#9798

Differential Revision: D9034663

Pulled By: virtan

fbshipit-source-id: d722f25f1dd00231ccc3ad5960bbbef63af02c2d
goodlux pushed a commit to goodlux/pytorch that referenced this pull request Aug 15, 2018
Summary: Pull Request resolved: pytorch#9798

Differential Revision: D9034663

Pulled By: virtan

fbshipit-source-id: d722f25f1dd00231ccc3ad5960bbbef63af02c2d
@ezyang ezyang added the merged label Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants