Move scalar boolean to THTensor, rename scalar in this context to zer… #9783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o dim. Manifest: 1) The scalar boolean is now in THTensor, although it isn't hooked up at the TH level yet. 2) setScalar is gone, everything now goes through the maybeScalar equivalent (which is renamed) 3) all "scalars" in this context now refer to "zero_dim" in order to differentiate this concept from the "Scalar" class.
gchanan
requested review from
apaszke,
colesbury,
ezyang,
soumith and
zdevito
as code owners
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ezyang
reviewed
Jul 24, 2018
aten/src/TH/THTensor.hpp
Outdated
| std::vector<int64_t> sizes_; | ||
| std::vector<int64_t> strides_; | ||
|
|
||
| // TODO: get rid of this, use the sizes_/strides_ .size() instead |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
approved these changes
Jul 24, 2018
Contributor
Author
|
New comment: |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@pytorchbot retest this please |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 25, 2018
…… (#9783) Summary: …o dim. Manifest: 1) The scalar boolean is now in THTensor, although it isn't hooked up at the TH level yet. 2) setScalar is gone, everything now goes through the maybeScalar equivalent (which is renamed) 3) all "scalars" in this context now refer to "zero_dim" in order to differentiate this concept from the "Scalar" class. Pull Request resolved: pytorch/pytorch#9783 Differential Revision: D8978911 Pulled By: gchanan fbshipit-source-id: f09254be4bebad0e4c510fefe4158b4f7e92efe1
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
pytorch#9783) Summary: …o dim. Manifest: 1) The scalar boolean is now in THTensor, although it isn't hooked up at the TH level yet. 2) setScalar is gone, everything now goes through the maybeScalar equivalent (which is renamed) 3) all "scalars" in this context now refer to "zero_dim" in order to differentiate this concept from the "Scalar" class. Pull Request resolved: pytorch#9783 Differential Revision: D8978911 Pulled By: gchanan fbshipit-source-id: f09254be4bebad0e4c510fefe4158b4f7e92efe1
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
pytorch#9783) Summary: …o dim. Manifest: 1) The scalar boolean is now in THTensor, although it isn't hooked up at the TH level yet. 2) setScalar is gone, everything now goes through the maybeScalar equivalent (which is renamed) 3) all "scalars" in this context now refer to "zero_dim" in order to differentiate this concept from the "Scalar" class. Pull Request resolved: pytorch#9783 Differential Revision: D8978911 Pulled By: gchanan fbshipit-source-id: f09254be4bebad0e4c510fefe4158b4f7e92efe1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o dim.
Manifest: