Skip to content

[Inductor] support vertical reduction in cpp #97644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jgong5 wants to merge 11 commits into from
Closed

[Inductor] support vertical reduction in cpp #97644

jgong5 wants to merge 11 commits into from

Conversation

@jgong5
Copy link
Collaborator

@jgong5 jgong5 commented Mar 27, 2023 •
edited
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 27, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/97644

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e897e89:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@jgong5 jgong5 mentioned this pull request Mar 27, 2023
Closed
Update on "[Inductor] support vertical reduction in cpp"
9a1b820 
cc soumith voznesenskym penguinwu anijain2305 EikanWang Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
jgong5 pushed a commit that referenced this pull request Mar 27, 2023
[Inductor] support vertical reduction in cpp
66b63cd 
ghstack-source-id: f100d8c
Pull Request resolved: #97644
@jgong5 jgong5 mentioned this pull request Mar 28, 2023
Closed
Jiong Gong added 3 commits March 30, 2023 14:09
Update on "[Inductor] support vertical reduction in cpp"
608eb3b 
cc soumith voznesenskym penguinwu anijain2305 EikanWang Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
Update on "[Inductor] support vertical reduction in cpp"
af8215e 
cc soumith voznesenskym penguinwu anijain2305 EikanWang Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
Update on "[Inductor] support vertical reduction in cpp"
733898a 
cc soumith voznesenskym penguinwu anijain2305 EikanWang Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
@jgong5 jgong5 requested a review from blzheng March 31, 2023 12:59
Jiong Gong added 4 commits March 31, 2023 13:00
Update on "[Inductor] support vertical reduction in cpp"
9010f41 
cc soumith voznesenskym penguinwu anijain2305 EikanWang Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
Update on "[Inductor] support vertical reduction in cpp"
e17c2f5 
cc soumith voznesenskym penguinwu anijain2305 EikanWang Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
Update on "[Inductor] support vertical reduction in cpp"
0ee4f07 
cc soumith voznesenskym penguinwu anijain2305 EikanWang Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
Update on "[Inductor] support vertical reduction in cpp"
0b32e7c 
cc soumith voznesenskym penguinwu anijain2305 EikanWang Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
This was referenced Apr 1, 2023
Closed
Closed
Update on "[Inductor] support vertical reduction in cpp"
67f335a 
cc soumith voznesenskym penguinwu anijain2305 EikanWang Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
Update on "[Inductor] support vertical reduction in cpp"
e897e89 
cc soumith voznesenskym penguinwu anijain2305 EikanWang Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
@jgong5 jgong5 added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 2, 2023
@jgong5
Copy link
Collaborator Author

jgong5 commented Apr 3, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Apr 3, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Apr 3, 2023

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x ec4718129de157ecde9b8270ed02a256b2c7df83 returned non-zero exit code 1

Auto-merging test/inductor/test_cpu_repro.py
Auto-merging torch/_inductor/codegen/cpp.py
CONFLICT (content): Merge conflict in torch/_inductor/codegen/cpp.py
error: could not apply ec4718129de... [Inductor] support vertical reduction in cpp
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
Details for Dev Infra team Raised by workflow job

@jgong5
Copy link
Collaborator Author

jgong5 commented Apr 3, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Apr 3, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/jgong5/13/head branch June 8, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jansel jansel jansel approved these changes

@EikanWang EikanWang Awaiting requested review from EikanWang

@desertfire desertfire Awaiting requested review from desertfire

@blzheng blzheng Awaiting requested review from blzheng

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor open source release notes: inductor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jgong5 @pytorchmergebot @jansel @pytorchbot