[TENSOR MERGE] Devirtualize TensorImpl::toString #9758
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can hardly be called an improvement (we now have a giant switch-of-switches) but it was the simplest way I could think of devirtualizing this function in the short term. Probably need some sort of native function that gives string information about a tensor. Signed-off-by: Edward Z. Yang <[email protected]>
ezyang
requested review from
apaszke,
colesbury,
gchanan,
soumith and
zdevito
as code owners
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Signed-off-by: Edward Z. Yang <[email protected]>
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ezyang
changed the title
Signed-off-by: Edward Z. Yang <[email protected]>
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Signed-off-by: Edward Z. Yang <[email protected]>
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 24, 2018
Summary: This can hardly be called an improvement (we now print CPUFloatType instead of CPUFloatTensor) but it was the simplest way I could think of devirtualizing this function in the short term. Probably need some sort of native function that gives string information about a tensor. Signed-off-by: Edward Z. Yang <[email protected]> Approved in #9710 Pull Request resolved: pytorch/pytorch#9758 Differential Revision: D8966935 Pulled By: ezyang fbshipit-source-id: a4641affe0a6153f90cdd9f4f2a1100e46d1a2db
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
Summary: This can hardly be called an improvement (we now print CPUFloatType instead of CPUFloatTensor) but it was the simplest way I could think of devirtualizing this function in the short term. Probably need some sort of native function that gives string information about a tensor. Signed-off-by: Edward Z. Yang <[email protected]> Approved in pytorch#9710 Pull Request resolved: pytorch#9758 Differential Revision: D8966935 Pulled By: ezyang fbshipit-source-id: a4641affe0a6153f90cdd9f4f2a1100e46d1a2db
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: This can hardly be called an improvement (we now print CPUFloatType instead of CPUFloatTensor) but it was the simplest way I could think of devirtualizing this function in the short term. Probably need some sort of native function that gives string information about a tensor. Signed-off-by: Edward Z. Yang <[email protected]> Approved in pytorch#9710 Pull Request resolved: pytorch#9758 Differential Revision: D8966935 Pulled By: ezyang fbshipit-source-id: a4641affe0a6153f90cdd9f4f2a1100e46d1a2db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can hardly be called an improvement (we now print
CPUFloatType instead of CPUFloatTensor) but it was the
simplest way I could think of devirtualizing this function in
the short term. Probably need some sort of native function
that gives string information about a tensor.
Signed-off-by: Edward Z. Yang [email protected]
Approved in #9710