Fix default argument value for CTCGreedyDecoder op #9747
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normster
force-pushed
the
export-D8963635
branch
from
f9ec7e7 to
a9cdb27
Compare
Contributor
Author
|
@pytorchbot retest this please |
normster
force-pushed
the
export-D8963635
branch
from
a9cdb27 to
50c95b8
Compare
normster
force-pushed
the
export-D8963635
branch
from
50c95b8 to
40db6d9
Compare
Contributor
|
@pytorchbot retest this please |
Contributor
Author
|
@pytorchbot please retest this |
Contributor
|
@pytorchbot retest this please |
Summary: Pull Request resolved: pytorch#9747 Currently the ctc_greedy_decoder op initializes the `merge_repeated` argument only if it has been provided by the user. Change to initialize in all cases. Differential Revision: D8963635 fbshipit-source-id: 480ebe4e6c278aac3d02024cbbe138542a6bf48e
normster
force-pushed
the
export-D8963635
branch
from
40db6d9 to
1ffbf3e
Compare
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
Summary: Pull Request resolved: pytorch#9747 Currently the ctc_greedy_decoder op initializes the `merge_repeated` argument only if it has been provided by the user. Change to initialize in all cases. Reviewed By: houseroad Differential Revision: D8963635 fbshipit-source-id: 18955c7c26a77d9d7f5137e4dec085252ffabfeb
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Pull Request resolved: pytorch#9747 Currently the ctc_greedy_decoder op initializes the `merge_repeated` argument only if it has been provided by the user. Change to initialize in all cases. Reviewed By: houseroad Differential Revision: D8963635 fbshipit-source-id: 18955c7c26a77d9d7f5137e4dec085252ffabfeb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Currently the ctc_greedy_decoder op initializes the
merge_repeatedargument only if it has been provided by the user. Change to initialize in all cases.Differential Revision: D8963635