Add some user-friendly checks in pack padded symbolic to ensure thing… #9731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesr66a
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@jamesr66a has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
…s are the right type
jamesr66a
force-pushed
the
pack_padded_checks
branch
from
926b67a to
e8e56bd
Compare
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@jamesr66a has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@pytorchbot retest this please |
apaszke
reviewed
Jul 25, 2018
| if not isinstance(input, torch._C.Value): | ||
| raise RuntimeError("PackPadded requires `input` to be a Tensor") | ||
| if not isinstance(lengths, torch._C.Value): | ||
| raise RuntimeError("PackPadded requires `lengths` to be a Tensor") |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
pytorch#9731) Summary: …s are the right type Pull Request resolved: pytorch#9731 Reviewed By: soumith Differential Revision: D8958693 Pulled By: jamesr66a fbshipit-source-id: 7db1f86a85188fd2c84d0edaaaac6a096d64ba52
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
pytorch#9731) Summary: …s are the right type Pull Request resolved: pytorch#9731 Reviewed By: soumith Differential Revision: D8958693 Pulled By: jamesr66a fbshipit-source-id: 7db1f86a85188fd2c84d0edaaaac6a096d64ba52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s are the right type