[TENSOR MERGE] Devirtualize TensorImpl::toString #9710
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezyang
requested review from
apaszke,
colesbury,
gchanan,
soumith and
zdevito
as code owners
gchanan
approved these changes
Jul 23, 2018
ezyang
force-pushed
the
tensor-merge
branch
2 times, most recently
from
53083b8 to
beb71d8
Compare
ezyang
force-pushed
the
pr/devirtualize-tensor-tostring
branch
from
a5dfebd to
ea4abc0
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 24, 2018
Summary: Constituent PRs: - [x] #9553 Remove unnecessary functions from StorageDerived.h (by cpuhrsch, reviewed by ezyang) - [x] #9588 Use THTensor/Storage for THVoidTensor/Storage (by cpuhrsch , reviewed by gchanan) - [x] #9627 Delete context from tensor (by ezyang, reviewed by gchanan) - [x] #9641 Tensor reorganization (by ezyang, reviewed by gchanan ) - [x] #9647 Remove dim_ from THTensor (by cpuhrsch, reviewed by ezyang) - [x] #9650 Remove context (by cpuhrsch, reviewed by gchanan and ezyang) - [x] #9715 Fix Windows build in tensor merge PR (by ezyang, reviewed by gchanan and SsnL) Upcoming PRs which didn't make this cut: - [x] #9644 Stride move to TensorImpl, and nits (by ezyang, reviewed by gchanan) - [ ] #9652 Native localScalar (by ezyang, **UNREVIEWED AND FAILING TESTS**) - [x] #9710 Devirtualize TensorImpl::toString (by ezyang, reviewed by gchanan) - [ ] #9654 Use int64_t instead of ptrdiff_t for size / Rename flag to resizable_ (by cpuhrsch, **CHANGES REQUESTED AND FAILING TESTS**) Pull Request resolved: #9713 Reviewed By: gchanan Differential Revision: D8960882 Pulled By: ezyang fbshipit-source-id: 99747b2c5462c7ff6809b67aacb4197626408204
Summary: Approved in pytorch#9644 Pull Request resolved: pytorch#9749 Differential Revision: D8965336 Pulled By: ezyang fbshipit-source-id: d1b0763e592f298395621cfd684715dc0a550cd6
This can hardly be called an improvement (we now have a giant switch-of-switches) but it was the simplest way I could think of devirtualizing this function in the short term. Probably need some sort of native function that gives string information about a tensor. Signed-off-by: Edward Z. Yang <[email protected]>
ezyang
force-pushed
the
pr/devirtualize-tensor-tostring
branch
from
ea4abc0 to
f160aa8
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 24, 2018
Summary: This can hardly be called an improvement (we now print CPUFloatType instead of CPUFloatTensor) but it was the simplest way I could think of devirtualizing this function in the short term. Probably need some sort of native function that gives string information about a tensor. Signed-off-by: Edward Z. Yang <[email protected]> Approved in #9710 Pull Request resolved: #9758 Differential Revision: D8966935 Pulled By: ezyang fbshipit-source-id: a4641affe0a6153f90cdd9f4f2a1100e46d1a2db
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
Summary: Constituent PRs: - [x] pytorch#9553 Remove unnecessary functions from StorageDerived.h (by cpuhrsch, reviewed by ezyang) - [x] pytorch#9588 Use THTensor/Storage for THVoidTensor/Storage (by cpuhrsch , reviewed by gchanan) - [x] pytorch#9627 Delete context from tensor (by ezyang, reviewed by gchanan) - [x] pytorch#9641 Tensor reorganization (by ezyang, reviewed by gchanan ) - [x] pytorch#9647 Remove dim_ from THTensor (by cpuhrsch, reviewed by ezyang) - [x] pytorch#9650 Remove context (by cpuhrsch, reviewed by gchanan and ezyang) - [x] pytorch#9715 Fix Windows build in tensor merge PR (by ezyang, reviewed by gchanan and SsnL) Upcoming PRs which didn't make this cut: - [x] pytorch#9644 Stride move to TensorImpl, and nits (by ezyang, reviewed by gchanan) - [ ] pytorch#9652 Native localScalar (by ezyang, **UNREVIEWED AND FAILING TESTS**) - [x] pytorch#9710 Devirtualize TensorImpl::toString (by ezyang, reviewed by gchanan) - [ ] pytorch#9654 Use int64_t instead of ptrdiff_t for size / Rename flag to resizable_ (by cpuhrsch, **CHANGES REQUESTED AND FAILING TESTS**) Pull Request resolved: pytorch#9713 Reviewed By: gchanan Differential Revision: D8960882 Pulled By: ezyang fbshipit-source-id: 99747b2c5462c7ff6809b67aacb4197626408204
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
Summary: This can hardly be called an improvement (we now print CPUFloatType instead of CPUFloatTensor) but it was the simplest way I could think of devirtualizing this function in the short term. Probably need some sort of native function that gives string information about a tensor. Signed-off-by: Edward Z. Yang <[email protected]> Approved in pytorch#9710 Pull Request resolved: pytorch#9758 Differential Revision: D8966935 Pulled By: ezyang fbshipit-source-id: a4641affe0a6153f90cdd9f4f2a1100e46d1a2db
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Constituent PRs: - [x] pytorch#9553 Remove unnecessary functions from StorageDerived.h (by cpuhrsch, reviewed by ezyang) - [x] pytorch#9588 Use THTensor/Storage for THVoidTensor/Storage (by cpuhrsch , reviewed by gchanan) - [x] pytorch#9627 Delete context from tensor (by ezyang, reviewed by gchanan) - [x] pytorch#9641 Tensor reorganization (by ezyang, reviewed by gchanan ) - [x] pytorch#9647 Remove dim_ from THTensor (by cpuhrsch, reviewed by ezyang) - [x] pytorch#9650 Remove context (by cpuhrsch, reviewed by gchanan and ezyang) - [x] pytorch#9715 Fix Windows build in tensor merge PR (by ezyang, reviewed by gchanan and SsnL) Upcoming PRs which didn't make this cut: - [x] pytorch#9644 Stride move to TensorImpl, and nits (by ezyang, reviewed by gchanan) - [ ] pytorch#9652 Native localScalar (by ezyang, **UNREVIEWED AND FAILING TESTS**) - [x] pytorch#9710 Devirtualize TensorImpl::toString (by ezyang, reviewed by gchanan) - [ ] pytorch#9654 Use int64_t instead of ptrdiff_t for size / Rename flag to resizable_ (by cpuhrsch, **CHANGES REQUESTED AND FAILING TESTS**) Pull Request resolved: pytorch#9713 Reviewed By: gchanan Differential Revision: D8960882 Pulled By: ezyang fbshipit-source-id: 99747b2c5462c7ff6809b67aacb4197626408204
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: This can hardly be called an improvement (we now print CPUFloatType instead of CPUFloatTensor) but it was the simplest way I could think of devirtualizing this function in the short term. Probably need some sort of native function that gives string information about a tensor. Signed-off-by: Edward Z. Yang <[email protected]> Approved in pytorch#9710 Pull Request resolved: pytorch#9758 Differential Revision: D8966935 Pulled By: ezyang fbshipit-source-id: a4641affe0a6153f90cdd9f4f2a1100e46d1a2db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can hardly be called an improvement (we now have a giant
switch-of-switches) but it was the simplest way I could think
of devirtualizing this function in the short term. Probably
need some sort of native function that gives string information
about a tensor.
Stacked on #9652
Diff to review: https://github.com/pytorch/pytorch/pull/9710/files/dce2b78e44078dd83af87b10848fe115b71e266f..HEAD