Skip to content

Remove hacky python dispatcher fallthrough#96635

Closed
angelayi wants to merge 1 commit intomasterfrom
cf_pyd
Closed

Remove hacky python dispatcher fallthrough#96635
angelayi wants to merge 1 commit intomasterfrom
cf_pyd

Conversation

@angelayi
Copy link
Contributor

Ed's previous PRs in stack #96306 fixes #89037, but this PR just removes the original hacky fallthrough.

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 13, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96635

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d7a9986:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@angelayi
Copy link
Contributor Author

@pytorchbot rebase

@angelayi
Copy link
Contributor Author

@pytorchbot merge -g

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 23, 2023

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: -g

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci} ...

Try @pytorchbot --help for more info.

@angelayi
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 23, 2023
@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased cf_pyd onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout cf_pyd && git pull --rebase)

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@angelayi angelayi added the topic: not user facing topic category label Mar 23, 2023
@angelayi
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PyOperator.fallthrough(DispatchKey.PythonDispatcher) will cause infinite recursion during redispatch.

3 participants