Fix a testcase in logsoftmax onnx export #9660
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houseroad
requested review from
Yangqing,
anderspapitto,
dzhulgakov,
ezyang,
jamesr66a and
smessmer
as code owners
yinghai
reviewed
Jul 20, 2018
Contributor
yinghai
left a comment
yinghai
left a comment
There was a problem hiding this comment.
Why do we have this change?
Member
Author
|
@pytorchbot retest this please |
Member
Author
|
@yinghai since only both dim==axis==last dimension, they are equal. Otherwise, they means different things. |
Member
Author
|
@pytorchbot retest this please |
2 similar comments
Contributor
|
@pytorchbot retest this please |
Contributor
|
@pytorchbot retest this please |
Member
Author
|
@pytorchbot retest this please |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Member
Author
|
@pytorchbot retest this please |
bddppq
approved these changes
Jul 24, 2018
Member
Author
|
@pytorchbot retest this please |
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
Summary: We only support special case. The original dim is not supported by ONNX. Pull Request resolved: pytorch#9660 Reviewed By: bddppq Differential Revision: D8965507 Pulled By: houseroad fbshipit-source-id: 021dffdf0489c2d3a50bfd1e0c4cfd00d4a3d776
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: We only support special case. The original dim is not supported by ONNX. Pull Request resolved: pytorch#9660 Reviewed By: bddppq Differential Revision: D8965507 Pulled By: houseroad fbshipit-source-id: 021dffdf0489c2d3a50bfd1e0c4cfd00d4a3d776
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only support special case. The original dim is not supported by ONNX.