Guard include of cuda-only header comm.h #9656
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezyang
requested review from
apaszke,
colesbury,
gchanan,
soumith and
zdevito
as code owners
ezyang
force-pushed
the
pr/cuda-header-guard
branch
from
110422f to
bc322c5
Compare
Signed-off-by: Edward Z. Yang <[email protected]>
ezyang
force-pushed
the
pr/cuda-header-guard
branch
from
bc322c5 to
59c0234
Compare
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
|
@pytorchbot retest this please |
1 similar comment
Contributor
Author
|
@pytorchbot retest this please |
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
Summary: Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: pytorch#9656 Reviewed By: colesbury Differential Revision: D8941361 Pulled By: ezyang fbshipit-source-id: c18cb0e606ae0608e5892040192b8792ae542b74
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: pytorch#9656 Reviewed By: colesbury Differential Revision: D8941361 Pulled By: ezyang fbshipit-source-id: c18cb0e606ae0608e5892040192b8792ae542b74
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Edward Z. Yang [email protected]