Revert "[PyTorch] Use c10::FastMap for memoizing in Pickler (#96360)"#96547
Closed
izaitsevfb wants to merge 1 commit intopytorch:masterfrom
Closed
Revert "[PyTorch] Use c10::FastMap for memoizing in Pickler (#96360)"#96547izaitsevfb wants to merge 1 commit intopytorch:masterfrom
izaitsevfb wants to merge 1 commit intopytorch:masterfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96547
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 14efb81: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
Author
|
@pytorchbot merge -f 'PyTorch releng GH1 revert, internal test failures, see D43926671' |
seemethere
approved these changes
Mar 10, 2023
malfet
approved these changes
Mar 10, 2023
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 12, 2023
… (#96547) This reverts commit 69d3fa2. Reason: breaks internal meta tests. See [D43926671](https://www.internalfb.com/diff/D43926671) Pull Request resolved: pytorch/pytorch#96547 Approved by: https://github.com/seemethere, https://github.com/malfet
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 14, 2023
… (#96547) This reverts commit 69d3fa2. Reason: breaks internal meta tests. See [D43926671](https://www.internalfb.com/diff/D43926671) Pull Request resolved: pytorch/pytorch#96547 Approved by: https://github.com/seemethere, https://github.com/malfet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 69d3fa2.
Reason: breaks internal meta tests. See D43926671