Skip to content

[CI] Use different subdirectories for amp and float32 nightly perf run#96470

Closed
desertfire wants to merge 1 commit intogh/desertfire/94/basefrom
gh/desertfire/94/head
Closed

[CI] Use different subdirectories for amp and float32 nightly perf run#96470
desertfire wants to merge 1 commit intogh/desertfire/94/basefrom
gh/desertfire/94/head

Conversation

@desertfire
Copy link
Contributor

@desertfire desertfire commented Mar 10, 2023 •
edited
Loading

Stack from ghstack (oldest at bottom):

Summary: runner.py deletes its output_dir as its first step, so we need
to keep two separate subdirectories.

@desertfire
[CI] Use different subdirectories for amp and float32 nightly perf run
a8a17f9 
Summary: runner.py deletes its output_dir as its first step, so we need
to keep two separate subdirectories.

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 10, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96470

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a8a17f9:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

desertfire added a commit that referenced this pull request Mar 10, 2023
@desertfire
[CI] Use different subdirectories for amp and float32 nightly perf run
fc9538c 
Summary: runner.py deletes its output_dir as its first step, so we need
to keep two separate subdirectories.

ghstack-source-id: 429344f
Pull Request resolved: #96470
@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2023

This PR needs a label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

huydhn
huydhn approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think I can close #96398, as they are kind of equivalent. Unless you want to keep that flag for other use cases outside CI

@desertfire
Copy link
Contributor Author

desertfire commented Mar 10, 2023

@pytorchbot merge -f "run in nightly"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Mar 10, 2023

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 12, 2023
@desertfire @cyyever
[CI] Use different subdirectories for amp and float32 nightly perf ru…
637eb31 
…n (#96470)

Summary: runner.py deletes its output_dir as its first step, so we need
to keep two separate subdirectories.
Pull Request resolved: pytorch/pytorch#96470
Approved by: https://github.com/huydhn
@facebook-github-bot facebook-github-bot deleted the gh/desertfire/94/head branch June 8, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@weiwangmeta weiwangmeta Awaiting requested review from weiwangmeta

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@desertfire @pytorchmergebot @huydhn