[MPS] Allow float16 input to float32 LayerNorm#96430
Closed
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96430
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit 7ebe509: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
kulinseth
approved these changes
Mar 9, 2023
Contributor
Author
|
@pytorchbot merge |
Contributor
Author
|
@pytorchbot merge -f "MPS tests are green" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 12, 2023
Only for forward pass Subset of pytorch/pytorch#96208 Create constant with scalar using `input_mps_dtype` and use `reciprocalWithTensor` instead of `divisionWithPrimaryTensor:1.0 secondaryTensor:` Fixes pytorch/pytorch#96113 Pull Request resolved: pytorch/pytorch#96430 Approved by: https://github.com/kulinseth
ydwu4
added a commit
to ydwu4/pytorch
that referenced
this pull request
Mar 13, 2023
Only for forward pass Subset of pytorch#96208 Create constant with scalar using `input_mps_dtype` and use `reciprocalWithTensor` instead of `divisionWithPrimaryTensor:1.0 secondaryTensor:` Fixes pytorch#96113 Pull Request resolved: pytorch#96430 Approved by: https://github.com/kulinseth
brkirch
pushed a commit
to brkirch/pytorch
that referenced
this pull request
Apr 15, 2023
Only for forward pass Subset of pytorch#96208 Create constant with scalar using `input_mps_dtype` and use `reciprocalWithTensor` instead of `divisionWithPrimaryTensor:1.0 secondaryTensor:` Fixes pytorch#96113 Pull Request resolved: pytorch#96430 Approved by: https://github.com/kulinseth
malfet
added a commit
that referenced
this pull request
Apr 18, 2023
Only for forward pass Subset of #96208 Create constant with scalar using `input_mps_dtype` and use `reciprocalWithTensor` instead of `divisionWithPrimaryTensor:1.0 secondaryTensor:` Fixes #96113 Pull Request resolved: #96430 Approved by: https://github.com/kulinseth (cherry picked from commit 075a494)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only for forward pass
Subset of #96208
Create constant with scalar using
input_mps_dtypeand usereciprocalWithTensorinstead ofdivisionWithPrimaryTensor:1.0 secondaryTensor:Fixes #96113