Skip to content

Test the impact of 4 to 1 checks in each module#96361

Closed
wconstab wants to merge 1 commit intogh/wconstab/131/basefrom
gh/wconstab/131/head
Closed

Test the impact of 4 to 1 checks in each module#96361
wconstab wants to merge 1 commit intogh/wconstab/131/basefrom
gh/wconstab/131/head

Conversation

@wconstab
Copy link
Contributor

@wconstab wconstab commented Mar 8, 2023 •
edited
Loading

This is a simple ablation

  • first i revert my 'unsound _has_hools' PR, below in stack
  • then I do some useless optimization on the global hooks (next pr in stack, no effect on perf)
  • finally in this PR, i just cut 3 of the 4 module hook dicts from the fast path check, and get all my perf back

python benchmarks/dynamo/huggingface.py --only MobileBertForQuestionAnswering --inductor --train --performance
This PR: 1.269x
This the PR below 1.186x
The baseline from master (before the unsound revert): 1.266x

Stack from ghstack (oldest at bottom):

@wconstab wconstab mentioned this pull request Mar 8, 2023
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 8, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96361

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Merge Blocking SEVs

There is 1 active merge blocking SEVs. Please view them below:

If you must merge, use @pytorchbot merge -f.

❌ 36 Failures

As of commit 26f1fea:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@wconstab wconstab mentioned this pull request Mar 8, 2023
Closed
wconstab added a commit that referenced this pull request Mar 8, 2023
@wconstab
Test the impact of 4 to 1 checks in each module
70e23d8 
ghstack-source-id: eb3296b
Pull Request resolved: #96361
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

This PR needs a label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label May 8, 2023
@github-actions github-actions bot closed this Jun 7, 2023
@facebook-github-bot facebook-github-bot deleted the gh/wconstab/131/head branch July 7, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD Awaiting requested review from albanD

@jbschlosser jbschlosser Awaiting requested review from jbschlosser

Assignees

No one assigned

Labels

ciflow/inductor-perf-compare Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@wconstab