[PyTorch] add c10/util/FbcodeMaps.h#96359
Closed
swolchok wants to merge 2 commits intogh/swolchok/556/basefrom
Closed
[PyTorch] add c10/util/FbcodeMaps.h#96359swolchok wants to merge 2 commits intogh/swolchok/556/basefrom
swolchok wants to merge 2 commits intogh/swolchok/556/basefrom
Conversation
Allow us to use folly maps in fbcode and std maps for compatibility in OSS, extending what static runtime is already doing. Differential Revision: [D43926670](https://our.internmc.facebook.com/intern/diff/D43926670/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96359
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit efdee76: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
Author
|
perfectly happy to rename/rebrand this as necessary if "fbcode" is too specific; the general idea is "people should be able to get us to default to a better map if they have it available" |
ezyang
approved these changes
Mar 9, 2023
Allow us to use folly maps in fbcode and std maps for compatibility in OSS, extending what static runtime is already doing. Differential Revision: [D43926670](https://our.internmc.facebook.com/intern/diff/D43926670/) [ghstack-poisoned]
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 12, 2023
Allow us to use folly maps in fbcode and std maps for compatibility in OSS, extending what static runtime is already doing. Differential Revision: [D43926670](https://our.internmc.facebook.com/intern/diff/D43926670/) Pull Request resolved: pytorch/pytorch#96359 Approved by: https://github.com/ezyang
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Allow us to use folly maps in fbcode and std maps for compatibility in OSS, extending what static runtime is already doing.
Differential Revision: D43926670