Skip to content

[ONNX] Bump onnx submodule to release 1.13.1 from rc2#96325

Closed
BowenBao wants to merge 1 commit intogh/BowenBao/213/basefrom
gh/BowenBao/213/head
Closed

[ONNX] Bump onnx submodule to release 1.13.1 from rc2#96325
BowenBao wants to merge 1 commit intogh/BowenBao/213/basefrom
gh/BowenBao/213/head

Conversation

@BowenBao
Copy link
Collaborator

@BowenBao BowenBao commented Mar 8, 2023 •
edited
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 8, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96325

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Merge Blocking SEVs

There is 1 active merge blocking SEVs. Please view them below:

If you must merge, use @pytorchbot merge -f.

✅ No Failures

As of commit 0c0db6f:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Mar 8, 2023
BowenBao added a commit that referenced this pull request Mar 8, 2023
@BowenBao
[ONNX] Bump onnx to release 1.13.1 from rc2
4c42af7 
ghstack-source-id: 7fd57e9
Pull Request resolved: #96325
justinchuby
justinchuby reviewed Mar 8, 2023
View reviewed changes
.ci/onnx/test.sh
pip install -q --user ninja flatbuffers==2.0 numpy==1.22.4 onnxruntime==1.14.0 beartype==0.10.4
# TODO: change this when onnx 1.13.1 is released.
pip install --no-use-pep517 'onnx @ git+https://github.com/onnx/onnx@e192ba01e438d22ca2dedd7956e28e3551626c91'
pip install -q --user onnx==1.13.1
Copy link
Collaborator

@justinchuby justinchuby Mar 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

combine this line with that on top to save some install time?

Copy link
Collaborator Author

@BowenBao BowenBao Mar 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave that to next time to not re-trigger another round of CI since it's marginal improvement.

@justinchuby justinchuby added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 8, 2023
@BowenBao BowenBao marked this pull request as ready for review March 8, 2023 20:52
@BowenBao
Copy link
Collaborator Author

BowenBao commented Mar 8, 2023

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Mar 8, 2023

This PR updates submodules third_party/onnx

If those updates are intentional, please add "submodule" keyword to PR title/description.

@BowenBao BowenBao changed the title [ONNX] Bump onnx to release 1.13.1 from rc2 [ONNX] Bump onnx submodule to release 1.13.1 from rc2 Mar 8, 2023
@BowenBao
Copy link
Collaborator Author

BowenBao commented Mar 8, 2023

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Mar 8, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 12, 2023
@BowenBao @cyyever
[ONNX] Bump onnx submodule to release 1.13.1 from rc2 (#96325)
3fa4b81 
Pull Request resolved: pytorch/pytorch#96325
Approved by: https://github.com/justinchuby
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 12, 2023
@BowenBao @cyyever
[ONNX] Bump onnx submodule to release 1.13.1 from rc2 (#96325)
0d24c8d 
Pull Request resolved: pytorch/pytorch#96325
Approved by: https://github.com/justinchuby
ydwu4 added a commit to ydwu4/pytorch that referenced this pull request Mar 13, 2023
@ydwu4
[ONNX] Bump onnx submodule to release 1.13.1 from rc2 (pytorch#96325)
d5b76a7 
Pull Request resolved: pytorch#96325
Approved by: https://github.com/justinchuby
@facebook-github-bot facebook-github-bot deleted the gh/BowenBao/213/head branch June 8, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinchuby justinchuby justinchuby approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: onnx torch.onnx related changes that should show up in the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BowenBao @pytorchmergebot @justinchuby @pytorchbot