Correctly resolve dispatch keys for PyOperator#96306
Closed
ezyang wants to merge 6 commits intogh/ezyang/1894/basefrom
Closed
Correctly resolve dispatch keys for PyOperator#96306ezyang wants to merge 6 commits intogh/ezyang/1894/basefrom
ezyang wants to merge 6 commits intogh/ezyang/1894/basefrom
Conversation
Previously, we never actually used resolve_key, which meant that you had to register CPU/CUDA/etc all manually; none of the alias keys worked. Now they work. Signed-off-by: Edward Z. Yang <[email protected]> [ghstack-poisoned]
This was referenced Mar 8, 2023
github-actions
bot
requested review from
Chillee,
SherlockNoMad,
albanD,
antoniojkim,
bdhirsh,
jbschlosser,
miladm,
voznesenskym and
wconstab
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96306
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 787c071: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Previously, we never actually used resolve_key, which meant that you had to register CPU/CUDA/etc all manually; none of the alias keys worked. Now they work. Signed-off-by: Edward Z. Yang <ezyangmeta.com> [ghstack-poisoned]
Previously, we never actually used resolve_key, which meant that you had to register CPU/CUDA/etc all manually; none of the alias keys worked. Now they work. Signed-off-by: Edward Z. Yang <ezyangmeta.com> [ghstack-poisoned]
ezyang
added
release notes: composability
Skylion007
approved these changes
Mar 8, 2023
Previously, we never actually used resolve_key, which meant that you had to register CPU/CUDA/etc all manually; none of the alias keys worked. Now they work. Signed-off-by: Edward Z. Yang <ezyangmeta.com> [ghstack-poisoned]
Previously, we never actually used resolve_key, which meant that you had to register CPU/CUDA/etc all manually; none of the alias keys worked. Now they work. Signed-off-by: Edward Z. Yang <ezyangmeta.com> [ghstack-poisoned]
Previously, we never actually used resolve_key, which meant that you had to register CPU/CUDA/etc all manually; none of the alias keys worked. Now they work. Signed-off-by: Edward Z. Yang <ezyangmeta.com> [ghstack-poisoned]
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 12, 2023
Previously, we never actually used resolve_key, which meant that you had to register CPU/CUDA/etc all manually; none of the alias keys worked. Now they work. Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: pytorch/pytorch#96306 Approved by: https://github.com/Skylion007, https://github.com/zou3519
ydwu4
added a commit
to ydwu4/pytorch
that referenced
this pull request
Mar 13, 2023
Previously, we never actually used resolve_key, which meant that you had to register CPU/CUDA/etc all manually; none of the alias keys worked. Now they work. Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: pytorch#96306 Approved by: https://github.com/Skylion007, https://github.com/zou3519
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 27, 2023
Ed's previous PRs in stack #96306 fixes #89037, but this PR just removes the original hacky fallthrough. Pull Request resolved: #96635 Approved by: https://github.com/zhxchen17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Previously, we never actually used resolve_key, which meant that
you had to register CPU/CUDA/etc all manually; none of the alias
keys worked. Now they work.
Signed-off-by: Edward Z. Yang [email protected]