Rewrite fallthrough to more closely match how C++ works#96304
Closed
ezyang wants to merge 3 commits intogh/ezyang/1893/basefrom
Closed
Rewrite fallthrough to more closely match how C++ works#96304ezyang wants to merge 3 commits intogh/ezyang/1893/basefrom
ezyang wants to merge 3 commits intogh/ezyang/1893/basefrom
Conversation
Fallthrough is modeled as a mask which we use to remove keys from the compute dispatch key set for eligibility. It's possible this addresses #89037 in a better way than #95891 but I cannot easily tell as the original repro no longer works and the new PR does not have a test. Signed-off-by: Edward Z. Yang <[email protected]> [ghstack-poisoned]
github-actions
bot
requested review from
Chillee,
SherlockNoMad,
albanD,
antoniojkim,
bdhirsh,
jbschlosser,
miladm,
voznesenskym and
wconstab
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96304
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f7a0000: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Fallthrough is modeled as a mask which we use to remove keys from the compute dispatch key set for eligibility. It's possible this addresses #89037 in a better way than #95891 but I cannot easily tell as the original repro no longer works and the new PR does not have a test. Signed-off-by: Edward Z. Yang <ezyangmeta.com> [ghstack-poisoned]
ezyang
added
topic: not user facing
zou3519
approved these changes
Mar 8, 2023
Contributor
zou3519
left a comment
zou3519
left a comment
There was a problem hiding this comment.
Yeah, it is much better to be consistent with C++
Fallthrough is modeled as a mask which we use to remove keys from the compute dispatch key set for eligibility. It's possible this addresses #89037 in a better way than #95891 but I cannot easily tell as the original repro no longer works and the new PR does not have a test. Signed-off-by: Edward Z. Yang <ezyangmeta.com> [ghstack-poisoned]
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
albanD
approved these changes
Mar 8, 2023
zhxchen17
approved these changes
Mar 8, 2023
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 12, 2023
Fallthrough is modeled as a mask which we use to remove keys from the compute dispatch key set for eligibility. It's possible this addresses pytorch/pytorch#89037 in a better way than pytorch/pytorch#95891 but I cannot easily tell as the original repro no longer works and the new PR does not have a test. Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: pytorch/pytorch#96304 Approved by: https://github.com/zou3519, https://github.com/albanD, https://github.com/zhxchen17
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 12, 2023
Fallthrough is modeled as a mask which we use to remove keys from the compute dispatch key set for eligibility. It's possible this addresses pytorch/pytorch#89037 in a better way than pytorch/pytorch#95891 but I cannot easily tell as the original repro no longer works and the new PR does not have a test. Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: pytorch/pytorch#96304 Approved by: https://github.com/zou3519, https://github.com/albanD, https://github.com/zhxchen17
ydwu4
added a commit
to ydwu4/pytorch
that referenced
this pull request
Mar 13, 2023
Fallthrough is modeled as a mask which we use to remove keys from the compute dispatch key set for eligibility. It's possible this addresses pytorch#89037 in a better way than pytorch#95891 but I cannot easily tell as the original repro no longer works and the new PR does not have a test. Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: pytorch#96304 Approved by: https://github.com/zou3519, https://github.com/albanD, https://github.com/zhxchen17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Fallthrough is modeled as a mask which we use to remove keys from the
compute dispatch key set for eligibility.
It's possible this addresses #89037
in a better way than #95891 but I
cannot easily tell as the original repro no longer works and the new PR
does not have a test.
Signed-off-by: Edward Z. Yang [email protected]