Refactor to reduce duplicate logic in torch._ops#96302
Closed
ezyang wants to merge 4 commits intogh/ezyang/1892/basefrom
Closed
Refactor to reduce duplicate logic in torch._ops#96302ezyang wants to merge 4 commits intogh/ezyang/1892/basefrom
ezyang wants to merge 4 commits intogh/ezyang/1892/basefrom
Conversation
Signed-off-by: Edward Z. Yang <[email protected]> [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96302
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 23a2bd7: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
requested review from
Chillee,
SherlockNoMad,
albanD,
antoniojkim,
bdhirsh,
jbschlosser,
miladm,
voznesenskym and
wconstab
Signed-off-by: Edward Z. Yang <ezyangmeta.com> [ghstack-poisoned]
This was referenced Mar 8, 2023
Signed-off-by: Edward Z. Yang <ezyangmeta.com> [ghstack-poisoned]
zou3519
approved these changes
Mar 8, 2023
Contributor
zou3519
left a comment
zou3519
left a comment
There was a problem hiding this comment.
Cool!
type hints and lint warnings are real
| # NB: This name is hard-coded in torch/csrc/autograd/python_variable.cpp | ||
| # for use with OpOverload; cache lookup is done entirely from C++ | ||
| # for speed. | ||
| # TODO: The cache is NOT currently used by PyOperator, but it should! |
Contributor
There was a problem hiding this comment.
nit: file issue when you merge this?
Contributor
Author
There was a problem hiding this comment.
This is fixed later in the stack!
|
|
||
| def py_impl(self, dispatch_key, fn): | ||
| pass | ||
| def py_impl(self, k): |
Contributor
There was a problem hiding this comment.
nit: k -> key for readability? Though i guess it's not really a key anymore, it's either a key, python mode, or a transform type
Contributor
Author
There was a problem hiding this comment.
Yeah, the old name was really long and so I figured let's just use a short meaningless identifier
Signed-off-by: Edward Z. Yang <ezyangmeta.com> [ghstack-poisoned]
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 12, 2023
Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: pytorch/pytorch#96302 Approved by: https://github.com/zou3519
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 12, 2023
Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: pytorch/pytorch#96302 Approved by: https://github.com/zou3519
ydwu4
added a commit
to ydwu4/pytorch
that referenced
this pull request
Mar 13, 2023
Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: pytorch#96302 Approved by: https://github.com/zou3519
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Signed-off-by: Edward Z. Yang [email protected]