Skip to content

Assert that there are no None arguments to backwards#96300

Closed
ezyang wants to merge 1 commit intogh/ezyang/1891/basefrom
gh/ezyang/1891/head
Closed

Assert that there are no None arguments to backwards#96300
ezyang wants to merge 1 commit intogh/ezyang/1891/basefrom
gh/ezyang/1891/head

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Mar 8, 2023 •
edited
Loading

Stack from ghstack (oldest at bottom):

This assert would have caught #96219

Signed-off-by: Edward Z. Yang [email protected]

@ezyang
Assert that there are no None arguments to backwards
c8c06a8 
This assert would have caught #96219

Signed-off-by: Edward Z. Yang <[email protected]>

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 8, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96300

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit c8c06a8:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang added a commit that referenced this pull request Mar 8, 2023
@ezyang
Assert that there are no None arguments to backwards
d735fb3 
This assert would have caught #96219

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: 6bfc9f7
Pull Request resolved: #96300
@ezyang
Copy link
Contributor Author

ezyang commented Mar 8, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 8, 2023
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Mar 8, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Mar 8, 2023

Merge failed

Reason: 1 jobs have failed, first few of them are: inductor / cuda11.8-py3.10-gcc7-sm86 / test (inductor_timm_dynamic, 2, 2, linux.g5.4xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@ezyang
Copy link
Contributor Author

ezyang commented Mar 9, 2023

@pytorchbot merge -f "spurious accuracy failure"

@ezyang ezyang closed this Mar 9, 2023
@ezyang ezyang reopened this Mar 9, 2023
@github-actions github-actions bot requested a review from bdhirsh March 9, 2023 22:11
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Mar 9, 2023

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 12, 2023
@ezyang @cyyever
Assert that there are no None arguments to backwards (#96300)
5466479 
This assert would have caught pytorch/pytorch#96219

Signed-off-by: Edward Z. Yang <[email protected]>
Pull Request resolved: pytorch/pytorch#96300
Approved by: https://github.com/bdhirsh
ydwu4 added a commit to ydwu4/pytorch that referenced this pull request Mar 13, 2023
@ydwu4
Assert that there are no None arguments to backwards (pytorch#96300)
a48652e 
This assert would have caught pytorch#96219

Signed-off-by: Edward Z. Yang <[email protected]>
Pull Request resolved: pytorch#96300
Approved by: https://github.com/bdhirsh
@facebook-github-bot facebook-github-bot deleted the gh/ezyang/1891/head branch June 8, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdhirsh bdhirsh bdhirsh approved these changes

@albanD albanD Awaiting requested review from albanD

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@Chillee Chillee Awaiting requested review from Chillee

@jbschlosser jbschlosser Awaiting requested review from jbschlosser

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

@voznesenskym voznesenskym Awaiting requested review from voznesenskym

@wconstab wconstab Awaiting requested review from wconstab

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: AO frontend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ezyang @pytorchmergebot @bdhirsh